Skip to content

Add CI workflow to run integration tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

MatteoPologruto
Copy link
Contributor

On every push and pull request that affects relevant files, run the integration tests.

The test checks if setup-protoc works correctly when version has the .x wildcard. Right now, 3.x downloads the latest protoc version, so the test must either be updated manually until 4.x is released or removed. Unfortunately it's not possible to use 2.x because 2.6.1 does not work on the github runners.

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 15, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 15, 2022
On every push and pull request that affects relevant files, run the integration tests.
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo for this important addition to the project infrastructure. It will allow us to more efficiently and effectively maintain and develop this project.


I would like to note that the results of the integration tests will not consistently reflect the state of the codebase until we have changed the project management to the "always repackage" policy we have established in our actions since the time this one was created:

@MatteoPologruto MatteoPologruto merged commit 39d6187 into arduino:master Dec 19, 2022
@MatteoPologruto MatteoPologruto deleted the test-integration branch December 19, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants